Towards Meargeable patch submissions for glibc

Siddhesh Poyarekar siddhesh@gotplt.org
Mon Sep 3 15:43:00 GMT 2018


On Monday 03 September 2018 09:06 PM, Joseph Myers wrote:
> On Mon, 3 Sep 2018, Siddhesh Poyarekar wrote:
> 
>> I agree that is the ideal place to be in but it seems much harder to
>> auto-generate a full ChangeLog entry in that manner and not something I
> 
> Such a script specifically does not need to generate a full ChangeLog
> entry (with separate descriptions of what changed in each entity), just a
> list of changed entities.

Ah OK, that's still not easy, but not that bad.  It may not be able to 
do things like finding macro scope for [!MACRO_DEF] like entries without 
a full scale parser.

>> That is, it is less about ChangeLog formats and more about getting it out of
>> the patch body.  Would you be in favour of this decoupling?
> 
> I suspect there will be enough badly formatted commit messages that you'd
> need to keep fixing things up after them, or to add hooks to check commits
> on master for the required formatting.  If there are too many such commits
> it might not save much work in the end (given it's not saving the main
> time sink with ChangeLog entries, which is writing them in the first
> place).

That's a fair point, let me take a stab at the ChangeLog file generation.

Siddhesh



More information about the Libc-alpha mailing list