[PATCH v2] Ensure mktime sets errno on error (bug 23789)

Andreas Schwab schwab@suse.de
Mon Oct 29 09:43:00 GMT 2018


On Okt 28 2018, "Albert ARIBAUD (3ADEV)" <albert.aribaud@3adev.fr> wrote:

> +  /* When __mktime_internal() returns -1, we need to know it it has set
> +   * errno (real error) or not (just returning valid time_t value -1),
> +   * so we beed to clear errno before calling __mktime_internal().
> +   * But we also need to preserve errno if __mktime_internal() does not
> +   * modify it, so we need to back up its current value.
> +   * Ditto for __tzset().  */

Style: GNU comment style.  No paren after function name.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list