[PATCH] signal: Use correct type for si_band in siginfo_t [BZ #23562]

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu Oct 18 18:21:00 GMT 2018



On 18/10/2018 13:56, Florian Weimer wrote:
> Perhaps I a SPARC maintainer could review this as well?
> 
> I tested it on x86-64 and found no regressions.  Based on the sources,
> the change should only impact SPARC.
> 
> 2018-10-18  Ilya Yu. Malakhov  <malakhov@mcst.ru>
> 
> 	[BZ #23562]
> 	* sysdeps/unix/sysv/linux/bits/types/siginfo_t.h
> 	(struct siginfo_t): Use correct type for si_band.
> 

LGTM, it seems to match kernel definition:

include/uapi/asm-generic/siginfo.h

120                 /* SIGPOLL */
121                 struct {
122                         __ARCH_SI_BAND_T _band; /* POLL_IN, POLL_OUT, POLL_MSG */
123                         int _fd;
124                 } _sigpoll;
				

arch/sparc/include/uapi/asm/siginfo.h

  8 #define __ARCH_SI_BAND_T int


> diff --git a/sysdeps/unix/sysv/linux/bits/types/siginfo_t.h b/sysdeps/unix/sysv/linux/bits/types/siginfo_t.h
> index 33766d1813..43c4e009a4 100644
> --- a/sysdeps/unix/sysv/linux/bits/types/siginfo_t.h
> +++ b/sysdeps/unix/sysv/linux/bits/types/siginfo_t.h
> @@ -107,7 +107,7 @@ typedef struct
>  	/* SIGPOLL.  */
>  	struct
>  	  {
> -	    long int si_band;	/* Band event for SIGPOLL.  */
> +	    __SI_BAND_TYPE si_band;	/* Band event for SIGPOLL.  */
>  	    int si_fd;
>  	  } _sigpoll;
>  
> 



More information about the Libc-alpha mailing list