[PATCH 2/2] soft-fp: Add the lack of implementation for 128 bit self-contained

[Joseph Myers]

On Mon, 15 Oct 2018, Zong Li wrote:

> Here only add the lack of implementation when building the RISC-V 32-bit
> port.

You're adding an implementation, not adding a lack of implementation 
(you're adding the implementation of the pieces that are needed by the 
RISC-V 32-bit port).  The same point applies to the proposed summary line 
for the commit.

> These marcos are used when the following situations occur at the same

s/marcos/macros/

> +	* soft-fp/op-8.h: Add macros for RV32 use.

Please see the GNU Coding Standards for how to write ChangeLog entries.  
In this case, you need to list all the new macros individually.

> +#define _FP_FRAC_CLZ_8(R, X)                    \

A previous review comment suggested a loop here.  You expressed a 
performance concern in 
<https://sourceware.org/ml/libc-alpha/2018-07/msg00929.html>.  Have you 
done any benchmarking since then to justify the concern and not making the 
suggested change?

-- 
Joseph S. Myers
joseph@codesourcery.com