[PATCH] _dl_exception_create_format: Support %x/%lx/%Zx

Joseph Myers joseph@codesourcery.com
Fri Nov 30 00:02:00 GMT 2018


On Thu, 29 Nov 2018, H.J. Lu wrote:

> This is what I actually checked in.

Your commit message doesn't say anything about how the commit was tested 
(please include that information in commit messages).  It causes a lot of 
build failures of the form:

dl-exception.c: In function '_dl_exception_create_format':
dl-exception.c:189:14: error: implicit declaration of function '_itoa' 
[-Werror=implicit-function-declaration]
   char *cp = _itoa (num, wptr, 16, 0);
              ^~~~~
dl-exception.c:189:14: error: initialization of 'char *' from 'int' makes 
pointer from integer without a cast [-Werror=int-conversion]
dl-exception.c:202:16: error: initialization of 'char *' from 'int' makes 
pointer from integer without a cast [-Werror=int-conversion]
     char *cp = _itoa (num, wptr, 16, 0);
                ^~~~~

(on aarch64, arm, hppa, i486, m68k, mips, ...)

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list