[PATCH] Add --no-hard-links option to localedef (Bug 23923)

Joseph Myers joseph@codesourcery.com
Mon Nov 26 16:59:00 GMT 2018


On Mon, 26 Nov 2018, Carlos O'Donell wrote:

> If the downstream distro wants to post-process the hardlinks then
> the time spent in localedef looking up sibling directories and
> processing hardlinks is wasted effort.

Do you have figures for the time involved?

> +     other locales, and see if we can reuse it, to save disk space.
> +     If the user specified --no-hard-link to localedef then hard_links is
> +     false, other_paths remains NULL and we skip the optimization below.
> +     The use of --no-hard-link is distribution specific since some distros
> +     have post-processing hard-link steps and so doing this here is a waste
> +     of time.  */

This should refer to --no-hard-links, not --no-hard-link (twice).

This is not a review of other aspects of the patch (but I approve of 
improving determinism of the locale build, and also have such a hard-link 
post-processing step at Mentor).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list