[PATCH] ld.so: command argument "--preload"

Florian Weimer fweimer@redhat.com
Wed Nov 7 14:06:00 GMT 2018


* David Newall:

> On 8/11/18 12:02 am, Florian Weimer wrote:
>>>   +tst-rtld-preload-OBJS =  $(subst $(empty) ,:,$(strip
>>> $(preloadtest-preloads:=.so)))
>>> +$(objpfx)tst-rtld-preload.out: tst-rtld-preload.sh $(objpfx)ld.so \
>>> +			       $(objpfx)preloadtest
>> Missing dependency on the objects in $(tst-rtld-preload-OBJS), I think.

> I think not.  This is the same as preloadtest-ENV (without
> "LD_PRELOAD=").  Is it okay?  Should I have included a comment to
> explain this?

preloadtest.out has this:

$(objpfx)preloadtest.out: $(preloadtest-preloads:%=$(objpfx)%.so)
preloadtest-ENV = \
  LD_PRELOAD=$(subst $(empty) ,:,$(strip $(preloadtest-preloads:=.so)))

So I think you should add $(preloadtest-preloads:%=$(objpfx)%.so) as
well.

Thanks,
Florian



More information about the Libc-alpha mailing list