[PATCH] Unconditionally call __gconv_get_path when reading iconv configuration

Florian Weimer fweimer@redhat.com
Mon Nov 5 11:46:00 GMT 2018


* Arjun Shankar:

> __gconv_read_conf is only ever called once during the program's lifetime.
> This means that __gconv_path_elem is always uninitialized when the function
> begins executing.  __gconv_get_path has an assert to ensure that this
> expected runtime behaviour is always exhibited.  Given this, checking for a
> NULL value before calling __gconv_get_path is unnecessary.  This commit
> drops the condition and calls __gconv_get_path unconditionally.
>
> ChangeLog:
>
> 2018-11-01  Arjun Shankar  <arjun@redhat.com>
>
> 	* iconv/gconv_conf.c (__gconv_read_conf): Remove NULL check for
> 	__gconv_path_elem and call __gconv_get_path unconditionally.

This is okay.

Thanks,
Florian



More information about the Libc-alpha mailing list