[PATCH v2 02/12] nds32: ABI Implementation

[Joseph Myers]

On Wed, 30 May 2018, Vincent Chen wrote:

> +typedef struct __jmp_buf_internal_tag
> +  {
> +    /* Callee-saved registers: $r6 - $r14, $fp, $gp, $lp, $sp: $r28 - $r31.  */
> +    int __regs[13];
> +  } __jmp_buf[1] __attribute__((__aligned__ (8)));

Should have a space between '__attribute__' and '(('.

> +static void __mcount_internal (u_long frompc, u_long selfpc) __attribute_used__;
> +
> +#define _MCOUNT_DECL(frompc, selfpc) \
> +static void __mcount_internal (u_long frompc, u_long selfpc)
> +
> +
> +#define MCOUNT							\
> +void _mcount (u_long frompc)		      			\
> +{								\
> +  __mcount_internal (frompc, (u_long) RETURN_ADDRESS (0));	\

As in the RISC-V port review, "unsigned long int" should be used in place 
of the legacy u_long name.

-- 
Joseph S. Myers
joseph@codesourcery.com