[PATCH] i386: Do not attempt to change stack alignment

[Florian Weimer]

On 05/22/2018 11:54 AM, Andreas Schwab wrote:
> On Mai 22 2018, Florian Weimer <fweimer@redhat.com> wrote:
> 
>> On 05/22/2018 11:33 AM, Andreas Schwab wrote:
>>> On Mai 22 2018, Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>>> On 05/22/2018 11:21 AM, Andreas Schwab wrote:
>>>>> On Mai 22 2018, fweimer@redhat.com (Florian Weimer) wrote:
>>>>>
>>>>>> All supported GCC versions handle stack alignment as expected.
>>>>>
>>>>> Can you explain what is expected here?
>>>>
>>>> As required by the current i386 ABI.
>>>
>>> What is required, and how has the situation changed?
>>
>> This was the stack alignment ABI change for the introduction of the SSE2
>> ABI, so it's ancient history.
> 
> Are you sure?  Glibc used to use -mpreferred-stack-boundary=2, so I
> don't see how that is related to GCC.

Well, 4-byte alignment has been broken for a while now, and with STV, 
it's not just math code that is affected (even at -O2).

I don't really understand what you are after here. 
-mpreferred-stack-boundary=4 is the default, so the Makefile bits I 
removed are just a cleanup that was missed when the (rather broken) 
-mpreferred-stack-boundary=2 flag was removed.

Thanks,
Florian