[PATCH] locale: XFAIL newlocale usage in static binary (Bug 23164)

Carlos O'Donell carlos@redhat.com
Mon May 21 18:14:00 GMT 2018


There is a glibc optimization which allows for locale categories
to be removed during static compilation. There have been various
bugs for this support over the years, with bug 16915 being the
most recent. The solution there was to emit a reference to all the
categories to avoid any being removed. This fix, although it's in
the generic __nl_langinfo_l function, doesn't appear to be enough
to fix the case for a statically linked program that uses newlocale
and nl_langinfo_l. This commit doesn't fix the problem, but it does
add a XFAIL'd test case such that a fix can be applied against this
and the XFAIL removed. It's not entirely clear that the problem is
the same as that which was seen in bug 16915.

The commit makes tst-langinfo.c into a test driver for use by two
new tests which use setenv/nl_langinfo or newlocale/nl_langinfo_l,
both dynamic (which pass) and static (for which tst-langinfo-newlocale-static
fails and is XFAIL'd). In addition we add CURRENCY_SYMBOL test coverage
which was the original problem reported in the related gcc/C++ PR.

OK to commit?

-- 
Cheers,
Carlos.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-locale-XFAIL-newlocale-usage-in-static-binary-Bug-23.patch
Type: text/x-patch
Size: 13588 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180521/b1304404/attachment.bin>


More information about the Libc-alpha mailing list