[PATCH 2/2] x86-64/swapcontext: Restore the pointer into %rdx after syscall

Carlos O'Donell carlos@redhat.com
Wed May 2 04:46:00 GMT 2018


On 04/29/2018 06:08 PM, H.J. Lu wrote:
> On Sun, Apr 29, 2018 at 2:10 PM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 04/26/2018 02:17 PM, H.J. Lu wrote:
>>>
>>> +       /* Restore destroyed register into RDX which is preserved by
>>> +          the syscall.  */
>>> +       movq    %r12, %rdx
>>
>>
>> Again, this comment does not make sense without the other upcoming changes.
>>
> 
> Here is the patch to use it:
> 
> https://github.com/hjl-tools/glibc/commit/182ce0987aada98b2d606276d4aa4fbd2527031b
 
If we are doing a "flag-day" enable for ucontext, is there
any reason not to add additional space today that can be
used in the future?

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list