[PATCH] Replace strncpy with memccpy to fix -Wstringop-truncation.

Joseph Myers joseph@codesourcery.com
Fri Mar 23 01:17:00 GMT 2018


On Thu, 22 Mar 2018, Khem Raj wrote:

> 	* nis/nss_nisplus/nisplus-parser.c: Replace strncpy with memcpy to
> 	avoid -Wstringop-truncation.

Could you give more details of (a) in what circumstances (architecture, 
compiler, etc.) you get this warning and (b) why the truncation is 
correct?

Whatever build failure you got hasn't shown up with build-many-glibcs.py.  
Maybe that should include a configuration with --enable-obsolete-rpc 
--enable-obsolete-nsl to make sure that it tests building those bits of 
code that are disabled by default?

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list