[PATCH] Use correct includes in benchtests

Florian Weimer fweimer@redhat.com
Fri Mar 16 18:12:00 GMT 2018


On 03/16/2018 07:06 PM, Wilco Dijkstra wrote:
> Florian Weimer wrote:
> 
>> I think this broken --enable-static-pie builds for some reason:
>>
>> In file included from bench-timing-type.c:19:0:
>> bench-timing.h:19:0: error: "attribute_hidden" redefined [-Werror]
>>    #define attribute_hidden
>> In file included from <command-line>:0:0:
>> ./../include/libc-symbols.h:361:0: note: this is the location of the
>> previous definition
>>    # define attribute_hidden __attribute__ ((visibility ("hidden")))
>>
>> Any suggestions how to fix this?  Just stick an #undef attribute_hidden
>> in front of it?
> 
> Hmm that looks like a preincluded file, which is done just before we
> define _ISOMAC... So I wonder whether it would be better to fix
> Makeconfig to pre-includes after the CPPFLAGS rather than in the
> middle of it?

I think Zack's suggestion regarding the change of module will help here.

Thanks,
Florian



More information about the Libc-alpha mailing list