[PATCH] Use correct includes in benchtests

Florian Weimer fweimer@redhat.com
Fri Mar 16 17:22:00 GMT 2018


On 03/15/2018 03:29 PM, Wilco Dijkstra wrote:
> 2018-03-15  Wilco Dijkstra<wdijkstr@arm.com>
> 
> 	* benchtests/Makefile: Define _ISOMAC.
> 	* benchtests/bench-strcoll.c: Add missing sys/stat.h include.
> 	* benchtests/bench-string.h: Define inhibit_loop_to_libcall macro.
> 	* benchtests/bench-strstr.c: Define empty libc_hidden_builtin_def.
> 	* benchtests/bench-strtok.c (oldstrtok): Use rawmemchr.

I think this broken --enable-static-pie builds for some reason:

In file included from bench-timing-type.c:19:0:
bench-timing.h:19:0: error: "attribute_hidden" redefined [-Werror]
  #define attribute_hidden
In file included from <command-line>:0:0:
./../include/libc-symbols.h:361:0: note: this is the location of the 
previous definition
  # define attribute_hidden __attribute__ ((visibility ("hidden")))

Any suggestions how to fix this?  Just stick an #undef attribute_hidden 
in front of it?

Thanks,
Florian



More information about the Libc-alpha mailing list