[PATCH v2] [BZ 1190] Make EOF sticky in stdio.

Zack Weinberg zackw@panix.com
Tue Mar 13 12:37:00 GMT 2018


On Tue, Mar 13, 2018 at 5:54 AM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> On Mär 13 2018, Florian Weimer <fweimer@redhat.com> wrote:
>
>> On 03/12/2018 11:46 PM, Andreas Schwab wrote:
>>>> -   tst-ftell-append tst-fputws tst-bz22415
>>>> +   tst-ftell-append tst-fputws tst-bz22415 tst-fgetc-after-eof \
>>
>>> Spurious backslash.
>>
>> Some of us use this style to avoid spurious -/+ line changes, just to add
>> the backslash in a subsequent patch.
>
> That can easily go wrong.

Without expressing an opinion either way on whether this is good
style, it does not seem to be the practice in libio/Makefile in
general, so I have removed the offending backslash in the version of
the patch I just pushed to master.

zw



More information about the Libc-alpha mailing list