[PATCH 4/6] Remove slow paths from sin/cos
Steve Ellcey
sellcey@cavium.com
Fri Mar 9 21:50:00 GMT 2018
On Fri, 2018-03-09 at 15:50 +0000, Wilco Dijkstra wrote:
> For huge inputs use the improved do_sincos function as well.  Now no
> cases use
> the correction factor returned by do_sin, do_cos and TAYLOR_SIN, so
> remove it.
>
> ChangeLog:
> 2018-03-09  Wilco Dijkstra  <wdijkstr@arm.com>
>
> * sysdeps/ieee754/dbl-64/s_sin.c (TAYLOR_SIN): Remove cor
> parameter.
> (do_cos): Remove corp parameter and calculations.
> (do_sin): Likewise.
> (do_sincos): Remove cor variable.
> (__sin): Use do_sincos for huge inputs.
> (__cos): Likewise.
> * sysdeps/ieee754/dbl-64/s_sincos.c (__sincos): Likewise.
Did this patch get mangled in transit or something? Â I could apply
patches 1 through 3 with no problem (and no fuzzing) to ToT but when I
got to 4 I get errors. Â I may have mangled something on this end but I
treated this patch just like 1 through 3 and those worked fine. Â 5 and
6 have issues too but I think that is because 4 did not apply cleanly.
Steve Ellcey
sellcey@cavium.com
% patch -p1 < ~/diff.4
patching file sysdeps/ieee754/dbl-64/s_sin.c
Hunk #6 succeeded at 323 (offset -10 lines).
Hunk #7 succeeded at 354 (offset -10 lines).
Hunk #8 succeeded at 384 (offset -10 lines).
Hunk #9 succeeded at 392 (offset -10 lines).
Hunk #10 succeeded at 405 (offset -10 lines).
Hunk #11 succeeded at 440 (offset -10 lines).
Hunk #12 FAILED at 471.
Hunk #13 succeeded at 473 (offset -10 lines).
Hunk #14 succeeded at 488 (offset -10 lines).
1 out of 14 hunks FAILED -- saving rejects to file sysdeps/ieee754/dbl-
64/s_sin.c.rej
patching file sysdeps/ieee754/dbl-64/s_sincos.c
patch: **** malformed patch at line 240:
More information about the Libc-alpha
mailing list