[bz 22342] patch: fix netgroup cache keys

Carlos O'Donell carlos@redhat.com
Fri Mar 2 00:17:00 GMT 2018


On 03/01/2018 03:21 PM, DJ Delorie wrote:
> "Carlos O'Donell" <carlos@redhat.com> writes:
>> Why is this correct?
> 
> As noted in the referenced BZ, this is the only key in the database that
> doesn't include its trailing NUL.  In this particular case, it's
> problematic because there are *two* types of entries in the netgroup
> cache, and when the keys don't match the cache aging and timeouts don't
> work right.

What are the two types of entries? How do they arrive at the database?
What is the other code path that adds the null?

You are -><- close to having what I would want for a good commit message
which explains the exact source of the problem and makes it immediately
obvious that the fix has to be correct.

>> Please post a v2 with the commit message you intend to use
>> please.
> 
> Will do.
> 


-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list