[RFC PATCH v3 01/12] C-SKY: ABI related code

[Joseph Myers]

On Fri, 29 Jun 2018, Mao Han wrote:

> Codes in this patch contains lots of C-SKY ABI related code. They are written
> accroding to the registers assgnments, relocations, assemblly described
> in C-SKY CPU ABI Standards and C-SKY CPU manual.

Could you include direct URLs to PDFs of these manuals in the introduction 
to future versions of the patch series (like you gave URLs for your GCC / 
binutils / Linux git repositories)?

> +#ifndef __CSKYABIV2__
> +#error "No support for C-SKY ABIV1"

Preprocessor indentation, "# error" inside #if.

> +#else
> +# define CSKY_ABIV2
> +#endif

Why do you need this macro rather than just using the predefined 
__CSKYABIV2__ anywhere needing an ABI conditional?  (Right now, of course, 
any such ABI conditionals will just have #error for the ABIv1 case, like 
the one here.)

-- 
Joseph S. Myers
joseph@codesourcery.com