RFC V2 [2/2] test-in-container

DJ Delorie dj@redhat.com
Thu Jun 28 21:05:00 GMT 2018


> I like this interface for writing tests, but it doesn't quite work at
> present: the makefile doesn't know about the test dependency on
> libnss_test1.so.2 and libnss_test2.so.2, so you get spurious failures
> at high concurrency levels.

This is supposed to handle it, in nss/Makefile already:

$(patsubst %,$(objpfx)%.out,$(tests)) : \
	$(objpfx)/libnss_test1.so$(libnss_test1.so-version) \
	$(objpfx)/libnss_test2.so$(libnss_test2.so-version)

> Should these instructions be included in the makefile instead?

Well, two reasons not to...

1. There are a lot of shortcuts in that "syntax" that would be more
   complex in a plain Makefile.  Reducing the cost of adding lots of
   tests was one of the design considerations.

2. We run that script after we've locked and cleaned the testroot, which
   we can't do in the Makefile.



More information about the Libc-alpha mailing list