[PATCH] Initialize pad outside the conditional to prevent uninitialized data warnings.

Florian Weimer fweimer@redhat.com
Mon Jun 25 17:18:00 GMT 2018


On 06/25/2018 07:15 PM, Patsy Franklin wrote:
> Hi Florian,
> 
> On Mon, Jun 25, 2018 at 10:39 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 06/25/2018 04:18 PM, Patsy Franklin wrote:
>>>
>>> Prior to this change, valgrind warned about unitialized bytes on
>>> ppc64, ppc64le, s390x, and aarch64.
>>
>>
>> How come that valgrind warns when it's supposed to be uninitialized padding?
> 
> The problem occurs when the partially initialized struct is written to
> the file system.
> 
> I should have stated this in the original description.

Looks okay to me if you put this into the commit message.

Thanks,
Florian



More information about the Libc-alpha mailing list