RFC V3 [1/2] test-in-container

[Florian Weimer]

On 03/02/2018 12:05 AM, DJ Delorie wrote:
> +CFLAGS-test-container.c = \
> +		-DSRCDIR_PATH=\"`cd .. ; pwd`\" \
> +		-DOBJDIR_PATH=\"`cd $(objpfx)/..; pwd`\" \
> +		-DINSTDIR_PATH=\"${prefix}\" \
> +		-DLIBDIR_PATH=\"${libdir}\"


I think OBJDIR_PATH could be $(objdir).  It's also odd to see make 
variables expanded with ${…}.

Could you add variables (maybe support_srcdir, support_objdir, 
support_prefix, support_libdir) to a separate file under support/ and 
add matching declarations, perhaps in support/support.h?  This looks 
generally useful to me.

Thanks,
Florian