[PATCH 01/14] Prepare vfprintf to use __printf_fp/__printf_fphex with float128 arg

Joseph Myers joseph@codesourcery.com
Thu Jun 21 21:22:00 GMT 2018


On Wed, 20 Jun 2018, Gabriel F. T. Gomes wrote:

> +#if __HAVE_FLOAT128_UNLIKE_LDBL
> +# define PARSE_FLOAT_VA_ARG_EXTENDED(INFO)				      \
> +  if (LDBL_USES_FLOAT128 && is_long_double)				      \
> +    {									      \
> +      INFO.is_binary128 = 1;						      \
> +      the_arg.pa_float128 = va_arg (ap, _Float128);			      \
> +    }									      \
> +  else									      \
> +    {									      \
> +      PARSE_FLOAT_VA_ARG (INFO)						      \
> +    }

I'd expect all these macros to be implemented in the do { ... } while (0) 
style, so that they do genuinely act as single statements when followed by 
';', and then to be followed by ';' at the sites where they are used (so 
avoiding editors messing up indentation at / after those sites), unless 
there is some reason that convention can't work here.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list