[PATCH 03/12] Add a generic scalb implementation

[Tulio Magno Quites Machado Filho]

Joseph Myers <joseph@codesourcery.com> writes:

> On Tue, 19 Jun 2018, Tulio Magno Quites Machado Filho wrote:
>
>> Create templates for e_scabl, w_scalb and w_scalb_compat.
>
> I don't think w_scalb_compat should become a template,

Ack.

> just a new w_scalb (with the compat files having all their contents become
> conditional on LIBM_SVID_COMPAT).

float, double and long double define __USE_WRAPPER_TEMPLATE as:
#define __USE_WRAPPER_TEMPLATE !LIBM_SVID_COMPAT

So, I guess the current code is already covering this part.
Am I missing something?

> Then you don't need to do anything with M_K_STANDARD, 
> because __kernel_standard is only used in compat files (and note the 
> arguments passed to it are different numbers for float / double / long 
> double, so M_K_STANDARD in this patch isn't actually correct).  And 
> w_scalbF_compat would stay in libm-compat-calls, so no empty float128 
> version would be needed (whereas an empty float128 version of w_scalb 
> would be needed).

Agreed.

-- 
Tulio Magno