[PATCH v2 2/2] Y2038: make __tz_convert compatible with 64-bit-time

Paul Eggert eggert@cs.ucla.edu
Sat Jun 16 14:23:00 GMT 2018


Albert ARIBAUD wrote:
> if I remove the __ctime64 and __ctime64_r defines
> and then build glibc for x86_64-linux-gnu, the linker stage fails due to
> nis/nis_print.c lines 336 and 338 referring to an undefined ctime().

How about if we fix nis/nis_print.c to use localtime_r and strftime instead of 
ctime? ctime is not thread-safe, and ctime_r is problematic due to the potential 
problem of overrunning its output buffer when given outlandish timestamps, so 
such a fix should be made regardless of the Y2038 changes.



More information about the Libc-alpha mailing list