PING: [PATCH] benchtests: Add -f/--functions argument
Siddhesh Poyarekar
siddhesh@gotplt.org
Tue Jun 12 16:05:00 GMT 2018
On 06/12/2018 07:59 PM, H.J. Lu wrote:
> On Thu, May 24, 2018 at 10:40 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> On x86-64, there may be multiple IFUNC implementations for a given
>> function. But we may be only interested in a subset of them. This
>> patch adds -f/--functions argument to compare a subset of IFUNC
>> implementations.
>>
>> Any comments?
>>
>>
>> H.J.
>> ---
>> * benchtests/scripts/compare_strings.py (process_results): Add
>> funcs argument. Compare only functions which are selected.
>> (main): Check if base function is among selected functions.
>> Pass selected functions to process_results.
>> (__main__): Add -f/--functions argument.
>
> I rebased my patch against the current master.
>
> Any comments, objections?
Thanks, looks OK to me. I kinda dislike the idea of 7 arguments to
process_results but that probably is a separate cleanup.
Siddhesh
More information about the Libc-alpha
mailing list