[PATCH v2 05/12] nds32: Generic <math.h> and soft-fp Routines

Vincent Chen vincentc@andestech.com
Fri Jun 1 07:50:00 GMT 2018


On Fri, Jun 01, 2018 at 05:44:18AM +0800, Joseph Myers wrote:
> On Wed, 30 May 2018, Vincent Chen wrote:
> 
> > +    FE_TONEAREST =
> > +#define FE_TONEAREST	1
> > +      FE_TONEAREST,
> > +  };
> 
> As noted in RISC-V port review, C90 / C++98 don't support trailing commas 
> in enum definitions, so you shouldn't have a comma after the last element 
> of an enum defined in an installed header.
>

OK, I will remove the comma in the next version patch.

Thanks for your comment.


> -- 
> Joseph S. Myers
> joseph@codesourcery.com



More information about the Libc-alpha mailing list