[PATCHv3] Add convenience target 'install-locale-files'.

Carlos O'Donell carlos@redhat.com
Thu Jul 26 20:17:00 GMT 2018


On 07/26/2018 02:36 PM, Rical Jasan wrote:
> On 07/26/2018 11:03 AM, Carlos O'Donell wrote:
> ...
>> diff --git a/manual/install.texi b/manual/install.texi
>> index a8577dd610..2501586302 100644
>> --- a/manual/install.texi
>> +++ b/manual/install.texi
>> @@ -462,13 +462,27 @@ permissions on a pseudoterminal so it can be used by the calling process.
>>  If you are using a Linux kernel with the @code{devpts} filesystem enabled
>>  and mounted at @file{/dev/pts}, you don't need this program.
>>  
>> -After installation you might want to configure the timezone and locale
>> -installation of your system.  @Theglibc{} comes with a locale
>> -database which gets configured with @code{localedef}.  For example, to
>> -set up a German locale with name @code{de_DE}, simply issue the command
>> -@samp{localedef -i de_DE -f ISO-8859-1 de_DE}.  To configure all locales
>> -that are supported by @theglibc{}, you can issue from your build directory the
>> -command @samp{make localedata/install-locales}.
>> +After installation you should configure the timezone and install locales
>> +for your system.  The time zone configuration ensures that youre system
> 
> "your"

Fixed.

> Should there be a short NEWS entry about this?  I mention it because
> additions to INSTALL seem to almost always be accompanied by one.

We could. Done.

> Also, what about documenting the install_root=<prefix> option?  I
> recognize it as a common option, but it's still an option that packagers
> have to choose to use, so it wouldn't hurt to mention that we support
> it, especially since the content talks about installing the locale files
> /somewhere/ on the system (giving examples).  My first question about
> running a command whose name is "install-something" is, "Where?"

The use of install_root is not kosher. We actually should only use DESTDIR
as documented in the GNU Coding Standards. We set install_root from DESTDIR.
And we describe DESTDIR earlier in install.texi.

https://www.gnu.org/prep/standards/html_node/DESTDIR.html

I'll mention DESTDIR.

v3
- s/youre/your/g
- Mention DESTDIR.

Cheers,
Carlos.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-convenience-target-install-locale-files.patch
Type: text/x-patch
Size: 9734 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180726/44c9af64/attachment.bin>


More information about the Libc-alpha mailing list