[PATCH] Add the statx function

Florian Weimer fweimer@redhat.com
Thu Jul 26 15:16:00 GMT 2018


On 07/11/2018 12:01 PM, Szabolcs Nagy wrote:
> On 11/07/18 07:55, Florian Weimer wrote:
>> On 07/11/2018 08:53 AM, Andreas Schwab wrote:
>>> /usr/include/sys/stat.h:446:11: fatal error: bits/statx.h: No such 
>>> file or directory
>>>   # include <bits/statx.h>
>>>             ^~~~~~~~~~~~~~
>>
>> Okay, so this file should be an installed header.  I will commit a fix 
>> after testing.
>>
>> Any idea why our header tests do not catch this?
>>
> 
> because the glibc source tree does have bits/statx.h
> and all tests (incorrectly) run with internal headers
> in the include path (not just the installed ones).

I had hoped that the check-installed-headers-* tests would catch this, 
but clearly that's not the case.

> build-many-glibcs.py catches it though when building gcc
> (i've just run into this).

Only if GCC uses the header, right?  So it's only limited coverage 
because GCC aims to be portable and won't use obscure stuff.

Thanks,
Florian



More information about the Libc-alpha mailing list