[PATCH v2] soft-fp: Add the lack of implementation for 128 bit self-contained.

Zong Li zongbox@gmail.com
Thu Jul 26 12:45:00 GMT 2018


Joseph Myers <joseph@codesourcery.com> 於 2018年7月26日 週四 下午8:03寫道:
>
> On Thu, 26 Jul 2018, Zong Li wrote:
>
> > +          fa8_c = (fa8_c ?                                              \
> > +                   R##_f[fa8_i] <= X##_f[fa8_i] :                       \
> > +                   R##_f[fa8_i] < X##_f[fa8_i]);                        \
>
> GNU formatting breaks lines before operators, not after, so ? and : at
> start not end of lines.
>
> > +          fs8_c = (fs8_c ?                                              \
> > +                   R##_f[fs8_i] >= X##_f[fs8_i] :                       \
> > +                   R##_f[fs8_i] > X##_f[fs8_i]);                        \
>
> Likewise.
>
> > +          (R) += _FP_W_TYPE_SIZE*2;             \
>
> GNU formatting uses spaces around binary operators such as *.
>
> > +#define _FP_FRAC_ZEROP_8(X)                                             \
> > +  ((X##_f[0] | X##_f[1] | X##_f[2] | X##_f[3] |                         \
> > +    X##_f[4] | X##_f[5] | X##_f[6] | X##_f[7]) == 0)
>
> Again, break lines before not after operators, so | at start of line.
>
I will modify it. Thanks.



More information about the Libc-alpha mailing list