[PATCH] Fix C11 conformance issues

Florian Weimer fweimer@redhat.com
Wed Jul 25 17:24:00 GMT 2018


On 07/25/2018 07:18 PM, Joseph Myers wrote:
> On Wed, 25 Jul 2018, Florian Weimer wrote:
> 
>> On 07/25/2018 03:43 PM, Adhemerval Zanella wrote:
>>>    linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
>>> -			   $(common-objpfx)nptl/libpthread.a
>>> -linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
>>> -			  $(common-objpfx)crypt/libcrypt.a
>>> +			   $(static-thread-library)
>>
>> I've just realized this:
>>
>> Linking with the static thread library obscures linknamespace issues in libc.a
>> for symbols which are also defined in libpthread.a.  So this change is a bit
>> questionable.
> 
> The linknamespace code looks at every definition of a strong undefined
> symbol being resolved, not just the definition in a particular library.

So there is not a problem after all?

What seems to be a problem is that libpthread.a must now be C11-clean 
for its C11 symbols (which is currently not the case on Hurd).  But 
fixing that is probably not a bad idea anyway.

Florian



More information about the Libc-alpha mailing list