[PATCH v8 1/8] nptl: Add C11 threads thrd_* functions

Joseph Myers joseph@codesourcery.com
Wed Jul 25 10:29:00 GMT 2018


On Wed, 25 Jul 2018, Andreas Schwab wrote:

> On Feb 02 2018, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
> > @@ -197,7 +197,8 @@ linknamespace-libs-xsi = $(linknamespace-libs-posix) \
> >  			 $(common-objpfx)crypt/libcrypt.a
> >  linknamespace-libs-ISO = $(linknamespace-libs-isoc)
> >  linknamespace-libs-ISO99 = $(linknamespace-libs-isoc)
> > -linknamespace-libs-ISO11 = $(linknamespace-libs-isoc)
> > +linknamespace-libs-ISO11 = $(linknamespace-libs-isoc) \
> > +			   $(common-objpfx)nptl/libpthread.a
> >  linknamespace-libs-XPG4 = $(linknamespace-libs-isoc) \
> >  			  $(common-objpfx)crypt/libcrypt.a
> 
> You have reverted commit e69d994a63, which breaks --disable-crypt
> builds.

Also, the hardcoded reference to $(common-objpfx)nptl/libpthread.a should 
be $(static-thread-library).  As-is, the patch has broken the testsuite 
build for Hurd (not just introduced the expected failures from lack of 
support for C11 threads in HTL).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list