[PATCH 01/12] x86: Update vfork to pop shadow stack

[H.J. Lu]

On Mon, Jul 23, 2018 at 7:47 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> On 07/21/2018 10:20 AM, H.J. Lu wrote:
>> Since we can't change return address on shadow stack, if shadow stack
>> is in use, we need to pop shadow stack and jump back to caller directly.
>>
>>       * sysdeps/unix/sysv/linux/i386/vfork.S (SYSCALL_ERROR_HANDLER):
>>       Redefine if shadow stack is enabled.
>>       (SYSCALL_ERROR_LABEL): Likewise.
>>       (__vfork): Pop shadow stack and jump back to to caller directly
>>       when shadow stack is in use.
>>       * sysdeps/unix/sysv/linux/x86_64/vfork.S (SYSCALL_ERROR_HANDLER):
>>       Redefine if shadow stack is enabled.
>>       (SYSCALL_ERROR_LABEL): Likewise.
>>       (__vfork): Pop shadow stack and jump back to to caller directly
>>       when shadow stack is in use.
>> ---
>>  sysdeps/unix/sysv/linux/i386/vfork.S   | 54 ++++++++++++++++++++++++++
>>  sysdeps/unix/sysv/linux/x86_64/vfork.S | 35 +++++++++++++++++
>>  2 files changed, 89 insertions(+)
>
> OK with comment suggestion.
>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
>

This is what I checked in.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-bits-indirect-return.h.patch
Type: text/x-patch
Size: 7917 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180724/1ef1d95b/attachment.bin>