V2 [PATCH] Add <bits/indirect-return.h>

H.J. Lu hjl.tools@gmail.com
Wed Jul 18 23:52:00 GMT 2018


On Wed, Jul 18, 2018 at 3:39 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Wed, 18 Jul 2018, H.J. Lu wrote:
>
>> +/* __INDIRECT_RETURN is used on swapcontext() to indicate if it
>
> As per the GNU Coding Standards, don't use () to indicate you're referring
> to a function, only when referring to a function call with no arguments.

Fixed.

>> +/* On x86, swapcontext() returns via indirect branch when the shadow
>> +   stack is enabled.  Define __INDIRECT_RETURN to indicate if
>> +   swapcontext() returns via indirect branch.  */
>
> Likewise.

Fixed.

Here is the updated patch.  OK for master?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-bits-indirect-return.h.patch
Type: text/x-patch
Size: 7385 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180718/9e7751ac/attachment.bin>


More information about the Libc-alpha mailing list