[PATCH] x86/CET: Add tests with legacy non-CET shared objects

[H.J. Lu]

On Wed, Jul 18, 2018 at 2:08 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Wed, 18 Jul 2018, H.J. Lu wrote:
>
>> On Wed, Jul 18, 2018 at 1:19 PM, Joseph Myers <joseph@codesourcery.com> wrote:
>> > On Tue, 17 Jul 2018, H.J. Lu wrote:
>> >
>> >>       * sysdeps/x86/Makefile (tests): Add tst-legacy-1,
>> >>       tst-legacy-2, tst-legacy-2a, tst-legacy-3, tst-legacy-4,
>> >>       tst-legacy-4a, tst-legacy-4b and tst-legacy-4c.
>> >>       (modules-names): Add tst-legacy-mod-1, tst-legacy-mod-2 and
>> >>       tst-legacy-mod-4.
>> >
>> > I think the use of "legacy" without "cet" in test names is problematic.
>> > You mean legacy with respect to CET support, but there could be any number
>> > of new features with respect to which there are legacy objects (lacking
>> > support for the feature, or lacking markings indicating state with respect
>> > to the feature, or similar).  So I think the test names should all mention
>> > "cet" explicitly.
>>
>> Will rename tst-legacy-XX to tst-cet-legacy-XX be sufficient?
>
> Yes (that is, for the naming issue; I have not otherwise reviewed the
> substance of the tests).


Here is the updated patch.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-CET-Add-tests-with-legacy-non-CET-shared-objects.patch
Type: text/x-patch
Size: 16576 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180718/e31a8dbe/attachment.bin>