[PATCH] x86/CET: Add tests with legacy shared objects

Joseph Myers joseph@codesourcery.com
Wed Jul 18 20:19:00 GMT 2018


On Tue, 17 Jul 2018, H.J. Lu wrote:

> 	* sysdeps/x86/Makefile (tests): Add tst-legacy-1,
> 	tst-legacy-2, tst-legacy-2a, tst-legacy-3, tst-legacy-4,
> 	tst-legacy-4a, tst-legacy-4b and tst-legacy-4c.
> 	(modules-names): Add tst-legacy-mod-1, tst-legacy-mod-2 and
> 	tst-legacy-mod-4.

I think the use of "legacy" without "cet" in test names is problematic.  
You mean legacy with respect to CET support, but there could be any number 
of new features with respect to which there are legacy objects (lacking 
support for the feature, or lacking markings indicating state with respect 
to the feature, or similar).  So I think the test names should all mention 
"cet" explicitly.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list