[PATCH 00/10] Optimized math routines

Joseph Myers joseph@codesourcery.com
Tue Jul 17 21:59:00 GMT 2018


On Fri, 6 Jul 2018, Szabolcs Nagy wrote:

> I think I addressed all of his comments in an acceptable way,
> but i don't know if he had other concerns or if parts of the
> code he has not reviewed yet.

The missing information in comments in previous versions effectively 
prevented review of substantial parts of the code in those versions; 
comments are critical information about the interfaces between different 
parts of the code that are required for effective review (as well as for 
subsequent maintainability of the code).

I think these changes are far too high risk for this late in the freeze.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list