[PATCH v2 2/2] libc-abis: Define ABSOLUTE ABI [BZ #19818][BZ #23307]

Maciej W. Rozycki macro@mips.com
Thu Jul 5 17:10:00 GMT 2018


Hi Carlos,

> > +* The GNU C Library now has correct support for ABSOLUTE symbols
> > +  (SHN_ABS-relative symbols).  Previously such ABSOLUTE symbols were
> > +  relocated incorrectly or in some cases discarded.  The GNU linker can
> > +  make use of this newer semantics, but it must communicate it to the
> 
> Suggest:
> "make use of the corrected semantics, ..."

 Hmm, "semantics" is uncountable rather than plural[1], so I'm not sure if 
"this semantics" is actually a grammatical mistake (just like "Can I drink 
this milk?" is fine), but I'm fine with your suggestion.  I actually 
considered using "the" to avoid having this discussion. ;)

 Committed with your suggestion applied then.  Thank you for your review.

  Maciej

References:

[1] <https://www.oxfordlearnersdictionaries.com/definition/american_english/semantics>



More information about the Libc-alpha mailing list