[PATCH v2] malloc: Remove malloc hooks (Bug 23328)

Florian Weimer fw@deneb.enyo.de
Mon Jul 2 14:16:00 GMT 2018


* Carlos O'Donell:

> diff --git a/catgets/Makefile b/catgets/Makefile
> index 36f6a226c3..941e5cb4ea 100644
> --- a/catgets/Makefile
> +++ b/catgets/Makefile
> @@ -56,7 +56,8 @@ generated += tst-catgets.mtrace tst-catgets-mem.out
>  
>  generated-dirs += de
>  
> -tst-catgets-ENV = NLSPATH="$(objpfx)%l/%N.cat" LANG=de MALLOC_TRACE=$(objpfx)tst-catgets.mtrace
> +tst-catgets-ENV = NLSPATH="$(objpfx)%l/%N.cat" LANG=de MALLOC_TRACE=$(objpfx)tst-catgets.mtrace \
> +	LD_PRELOAD=$(objpfx)../malloc/libmalloc-extras.so

Should this be $(objpfx-common)malloc/libmalloc-extras.so instead?

Anyway, you should add a dependency on libmalloc-extras.so to
tst-catgets.out, or perhaps even link tst-catgets against
libmalloc-extras.so, so that the test is rerun once the DSO changes.
(This applies to other uses of mtrace, of course.)



More information about the Libc-alpha mailing list