RFC V2 [1/2] test-in-container

Florian Weimer fweimer@redhat.com
Wed Feb 28 14:11:00 GMT 2018


On 02/27/2018 10:09 PM, Andreas Schwab wrote:
>> +static void
>> +copy_one_file (const char *sname, const char *dname)
>> +{
>> +  int sfd, dfd;
>> +  char buf[512];
>> +  size_t rsz;
>> +  struct stat st;
>> +  struct utimbuf times;
>> +
>> +  sfd = open (sname, O_RDONLY);
>> +  if (sfd < 0)
>> +    {
>> +      printf ("unable to open %s for reading\n", sname);
>> +      perror ("the error was");

> That doesn't work, the printf call can clobber errno.  Use error instead.

Doesn't error print to standard error?

%m is another option.

Thanks,
Florian



More information about the Libc-alpha mailing list