RFC V2 [1/2] test-in-container

[Andreas Schwab]

On Feb 27 2018, DJ Delorie <dj@redhat.com> wrote:

> +static void
> +copy_one_file (const char *sname, const char *dname)
> +{
> +  int sfd, dfd;
> +  char buf[512];
> +  size_t rsz;
> +  struct stat st;
> +  struct utimbuf times;
> +
> +  sfd = open (sname, O_RDONLY);
> +  if (sfd < 0)
> +    {
> +      printf ("unable to open %s for reading\n", sname);
> +      perror ("the error was");

That doesn't work, the printf call can clobber errno.  Use error instead.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."