[PATCH] Define GEN_AS_CONST_HEADERS when generating header files [BZ #22792]

[H.J. Lu]

On Tue, Feb 20, 2018 at 11:09 PM, Florian Weimer <fweimer@redhat.com> wrote:
> On 02/08/2018 06:58 PM, H.J. Lu wrote:
>>
>>         [BZ #22792]
>>         * Makerules ($(common-objpfx)%.h): Pass -DGEN_AS_CONST_HEADERS
>>         to $(CC).
>>         * sysdeps/unix/sysv/linux/i386/lowlevellock.h: Include
>>         <tcb-offsets.h> only if GEN_AS_CONST_HEADERS isn't defined.
>>         * sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Don't include
>>         <tcb-offsets.h>.
>
>
> It looks to me that a cleaner fix would be to move the definition of the TCB
> types to a separate header.

I will take a look.

> The circular dependency is just a cosmetic warning from make, right?

It depends on how unlucky you are.  In one case on a many-core machine
with make -j60, I had to kill glibc build since it never stopped.


-- 
H.J.