[PATCH 2/2] nptl: Update struct pthread_unwind_buf [BZ #22743]

H.J. Lu hjl.tools@gmail.com
Thu Feb 8 18:42:00 GMT 2018


On Thu, Feb 8, 2018 at 5:27 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Feb 8, 2018 at 1:25 AM, Carlos O'Donell <carlos@redhat.com> wrote:

>
>> like that to indicate the intent is to make the structure match the layout
>> used by setjmp jump buffers.
>>
>> Both UNWIND_BUF_PRIV and THREAD_COPY_ADDITONAL_INFO are exmaples of typo-prone
>> macro APIs. We should work hard to define defaults and have unconditional
>> users of these macros such that -Wundef can warn us if we make mistakes
>> e.g. https://sourceware.org/glibc/wiki/Wundef
>
> Will do.
>

Here is the updated patch for struct pthread_unwind_buf .  Now UNWIND_BUF_PRIV
is defined unconditionally and THREAD_COPY_ADDITONAL_INFO is renamed to
THREAD_COPY_CANCEL_JMP_BUF_INFO which is also defined unconditionally.

Tested with build-many-glibcs.py.  OK for master?

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-nptl-Update-struct-pthread_unwind_buf-BZ-22743.patch
Type: text/x-patch
Size: 14805 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180208/2dc9d235/attachment.bin>


More information about the Libc-alpha mailing list