[PATCH v2 04/12] termios: Consolidate Input Modes definitions.
Siddhesh Poyarekar
siddhesh@gotplt.org
Mon Dec 31 15:46:00 GMT 2018
On 28/12/18 6:39 AM, Adhemerval Zanella wrote:
> This patch consolidates the termios symbolic constants used for input
> modes with c_iflag member on its own header. The Linux generic implementation
> values match the kernel UAPI and each architecture with deviate values
> have their own implementation (in this case alpha and powerpc).
>
> No semantic change is expected, checked on a build against x86_64-linux-gnu,
> alpha-linux-gnu, mips64-linux-gnu, and sparc64-linux-gnu.
>
> * sysdeps/unix/sysv/linux/Makefile (sysdeps_headers): Add termios-c_iflag.h.
> * sysdeps/unix/sysv/linux/bits/termios-c_iflag.h: New file.
> * sysdeps/unix/sysv/linux/alpha/bits/termios-c_iflag.h: Likewise.
> * sysdeps/unix/sysv/linux/powerpc/bits/termios-c_iflag.h: Likewise.
> * sysdeps/unix/sysv/linux/bits/termios.h (IGNBRK, BRKINT, IGNPAR, PARMRK,
> INPCK, ISTRIP, INLCR, IGNCR, ICRNL, IXON, IXOFF, IXANY, IUCLC, IMAXBEL,
> IUTF8): Move to termios-c_iflag.h.
> * sysdeps/unix/sysv/linux/alpha/bits/termios.h: Likewise.
> * sysdeps/unix/sysv/linux/mips/bits/termios.h: Likewise.
> * sysdeps/unix/sysv/linux/powerpc/bits/termios.h: Likewise.
> * sysdeps/unix/sysv/linux/sparc/bits/termios.h: Likewise.
OK. I wonder if it makes sense to redefine only the values that are
different in the deviating headers to avoid errors.
Siddhesh
More information about the Libc-alpha
mailing list