[PATCH] malloc: Always call memcpy in _int_realloc [BZ #24027]

[Siddhesh Poyarekar]

On 26/12/18 2:25 AM, Niklas Hambüchen wrote:
> Would it not make sense to first apply the patch I provided in
> 
>    https://sourceware.org/bugzilla/show_bug.cgi?id=24027
> 
> that fixes the type, and then do the removal of the memcpy special case as a refactoring?
> 
> That would ensure that if somebody disagrees with the performance-critical bit in the future and reverts this, they don't revert back to the bugged version.
> It would also make it possible for downstream distributions to cherry-pick a minimal patch from upstream.

I agree with your point about reverting buggy behaviour and I've 
suggested adding a note in the commit to guard against that.

It is Florian's discretion if he wants to split this into two commits 
like you suggest; it's not strictly necessary IMO (performance impact 
and revert risk are negligible and Florian's patch is also minimal 
enough for most distros) but is not that big a deal to do either.

Thanks,
Siddhesh