[PATCH 01/14] Prepare vfprintf to use __printf_fp/__printf_fphex with float128 arg
Florian Weimer
fweimer@redhat.com
Tue Dec 18 12:13:00 GMT 2018
* Gabriel F. T. Gomes:
> + } while (0)
Style issue: while should be on a separate line (occurs multiple times).
> @@ -1887,7 +1930,12 @@ printf_positional (FILE *s, const CHAR_T *format, int readonly_format,
> (args_value[cnt].pa_user, ap_savep);
> }
> else
> - args_value[cnt].pa_long_double = 0.0;
> + {
> + args_value[cnt].pa_long_double = 0.0;
> +#if __HAVE_FLOAT128_UNLIKE_LDBL
> + args_value[cnt].pa_float128 = 0;
> +#endif
> + }
This bit doesn't look right to me because args_value[cnt] is a union.
You need to assign to the right member, or perhaps zero-initialize using
memset.
Thanks,
Florian
More information about the Libc-alpha
mailing list