[PATCH] Reindent nptl/pthread_rwlock_common.c

Florian Weimer fweimer@redhat.com
Tue Dec 11 14:46:00 GMT 2018


* Andreas Schwab:

> @@ -338,8 +338,9 @@ __pthread_rwlock_rdlock_full (pthread_rwlock_t *rwlock,
>       expected value for future operations.  Acquire MO so we synchronize with
>       prior writers as well as the last reader of the previous read phase (see
>       below).  */
> -  r = atomic_fetch_add_acquire (&rwlock->__data.__readers,
> -      (1 << PTHREAD_RWLOCK_READER_SHIFT)) + (1 << PTHREAD_RWLOCK_READER_SHIFT);
> +  r = (atomic_fetch_add_acquire (&rwlock->__data.__readers,
> +				 (1 << PTHREAD_RWLOCK_READER_SHIFT))
> +       + (1 << PTHREAD_RWLOCK_READER_SHIFT));

Aren't some of these parentheses you are removing recommended for
getting correct indentation from Emacs?

(I do not particularly like them and think the identation without them
is just as fine, but others may disagree.)

Thanks,
Florian



More information about the Libc-alpha mailing list