[PATCH] support: Close original descriptors in support_capture_subprocess

Andreas Schwab schwab@linux-m68k.org
Sat Dec 1 20:20:00 GMT 2018


On Dez 01 2018, Florian Weimer <fweimer@redhat.com> wrote:

> This means that stdout_pipe[1] is at least 1 and stderr_pipe[1] is at
> least 3.  We can never close descriptor 0, but the first xclose could
> close descriptor 1 or 2.  Should I remove the second if condition?

IMHO it would be cleaner that if a test needs a closed standard fd there
should be a separate functionality to set that up instead of letting the
test close it directly.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."



More information about the Libc-alpha mailing list