[patch] Fix BZ 20271 -- missing newlines in __libc_fatal calls

Adhemerval Zanella adhemerval.zanella@linaro.org
Thu Aug 30 20:27:00 GMT 2018



On 25/08/2018 14:46, Paul Pluzhnikov wrote:
> Greetings,
> 
> Ok for trunk?
> 
> 2018-08-25  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
>         [BZ #20271]
>         * grp/initgroups.c (internal_getgrouplist): Add missing newline.
>         * nptl/pthread_cond_wait.c (__pthread_cond_wait_common): Likewise.
>         * nscd/initgrcache.c (addinitgroupsX): Likewise.
>         * nss/nsswitch.c (__nss_next2): Likewise.
>         * sysdeps/aarch64/dl-irel.h (elf_irela): Likewise.
>         * sysdeps/arm/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/generic/unwind-dw2.c (execute_cfa_program): Likewise.
>         * sysdeps/i386/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/powerpc/powerpc32/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/powerpc/powerpc64/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/s390/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/sparc/sparc32/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/sparc/sparc64/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/x86_64/dl-irel.h (elf_irel): Likewise.
>         * sysdeps/nptl/futex-internal.h (futex_wake): Likewise.
>         * sysdeps/unix/sysv/linux/netlink_assert_response.c
>         (__netlink_assert_response): Likewise.
> 

LGTM, I would also add a comment in include/stdio.h to state internal
convention is call with a newline terminated string.



More information about the Libc-alpha mailing list