[PATCHv2] Fix test failure with -DNDEBUG.
Carlos O'Donell
carlos@redhat.com
Thu Aug 30 15:43:00 GMT 2018
On 08/30/2018 11:13 AM, Florian Weimer wrote:
> On 08/30/2018 05:08 PM, Carlos O'Donell wrote:
>> Â Â Â Â Â Â Â rc = pthread_create (&thr, NULL, fn, NULL);
>> -Â Â Â Â Â assert (rc == 0);
>> +Â Â Â Â Â TEST_VERIFY (rc == 0);
>> Â Â Â Â Â Â Â Â rc = pthread_join (thr, NULL);
>> -Â Â Â Â Â assert (rc == 0);
>> +Â Â Â Â Â TEST_VERIFY (rc == 0);
>
> Both should actually be TEST_VERIFY_EXIT, I assume, and that would be
> close to xpthread_create and xpthread_join.
I might as well just cleanup the test.
v2
- Use xpthread_create, xpthread_join. The threads need to be started for
the test to validly use up slotinfo entries.
--
Cheers,
Carlos.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-test-failure-with-DNDEBUG.patch
Type: text/x-patch
Size: 2111 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20180830/b3c8acba/attachment.bin>
More information about the Libc-alpha
mailing list